Expose finding valid focus neighbors of a Control by side
#76027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
ControlControl by direction
AThousandShips
changed the title
Control by directionControl by side
AThousandShips
force-pushed
the
focus_direction
branch
from
2f6d461
to
ccf926f
Compare
|
There exists |
|
It's very similar, so will rename it as per my considered name |
AThousandShips
force-pushed
the
focus_direction
branch
from
ccf926f
to
0f1f11d
Compare
AThousandShips
force-pushed
the
focus_direction
branch
from
0f1f11d
to
5b5d157
Compare
YuriSizov
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Looks fine, but we should probably better document the relation between this method and get_focus_neighbor. They should be cross-linked with an appropriate note where and when to use each. Especially the behavior of the new method is worth explaining in more detail.
|
Will do! Unsure about the exact wording |
Exposes the functionality used for ui navigation
AThousandShips
force-pushed
the
focus_direction
branch
from
5b5d157
to
e70b83c
Compare
|
Not exactly sure about the wording but added some basic details |
YuriSizov
reviewed
Sep 25, 2023
| @@ -526,6 +526,7 @@ class Control : public CanvasItem { | |||
|
|
|||
| Control *find_next_valid_focus() const; | |||
| Control *find_prev_valid_focus() const; | |||
| Control *find_valid_focus_neighbor(Side p_size) const; | |||
There was a problem hiding this comment.
Oops 🙃
Suggested change
| Control *find_valid_focus_neighbor(Side p_size) const; | |
| Control *find_valid_focus_neighbor(Side p_side) const; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the functionality that is used for keyboard/joystick navigation to scripting, made it a constant function to match the other
find_functionsNamed it
find_valid_focus_neighborasget_focus_neighborwas already taken andfind_valid_conveys the functionality better I feel and matchesfind_next_valid/prev_focus,find_next_valid_focus_neighborfeels a bit too long but think this is a good balanceCloses godotengine/godot-proposals#6690