Allow EditorExportPlugins to provide export options #72895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedworkDE
force-pushed
the
editor-export-plugin-settings
branch
2 times, most recently
from
1f1f1fb
to
a01d903
Compare
RedworkDE
force-pushed
the
editor-export-plugin-settings
branch
from
a01d903
to
23ed628
Compare
RedworkDE
commented
Feb 13, 2023
| export_plugins.sort_custom<SortByName>(); | ||
|
|
||
| for (int i = 0; i < export_plugins.size(); i++) { | ||
| export_plugins.write[i]->set_export_preset(p_preset); |
There was a problem hiding this comment.
I moved this into the ExportNotifier above, or the options would not get read when exporting for a second time. Not sure why this was set here in the first place.
RedworkDE
force-pushed
the
editor-export-plugin-settings
branch
from
23ed628
to
6963e84
Compare
akien-mga
approved these changes
Apr 17, 2023
|
Thanks! |
|
@RedworkDE There's a bug with restoring the saved values for the editor export plugin options from the preset; see #78958 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically duplicates
get_export_optionsfromEditorExportPlatformtoEditorExportPluginand sets things up for scripting.This allows export plugins to to have export preset specific options that also show up in the export dialog.
Example (the Dotnet options are added from from the CSharpExport plugin):
Open issue: From scripts the options are always added to the very end of the options list so users always have to scroll to the very end to access them