Add Black (OLED) editor theme preset #67871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
editor-theme-add-oled-preset
branch
from
9f7c54d to
3b84ae4
Compare
Calinou
force-pushed
the
editor-theme-add-oled-preset
branch
2 times, most recently
from
fe8b6ba to
26e7772
Compare
Iniquitatis
reviewed
Oct 25, 2022
This preset uses a fully black background to reduce power usage on OLED displays, leading to increased battery life on laptops with OLED displays. This preset is also useful for late night sessions, as OLED displays have a near-infinite contrast ratio. This also adds a Draw Extra Borders editor setting which draws borders around some interactive nodes. This setting is required for good usability of a theme with a fully black background. Visibility of disabled text (including unselected tab names) has been slightly increased for better accessibility, regardless of the editor theme preset in use.
Calinou
force-pushed
the
editor-theme-add-oled-preset
branch
from
26e7772 to
f613db0
Compare
akien-mga
approved these changes
Nov 28, 2022
|
Thanks! |
|
Are there any plans to back-port this preset to 3.x? |
Adding a new built-in preset would break existing editor settings (as the Custom preset would be moved by one slot), so probably not. The Draw Extra Borders editor setting is also nontrivial to backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preset uses a fully black background to reduce power usage on OLED displays, leading to increased battery life on laptops with OLED displays.
This preset is also useful for late night sessions, as OLED displays have a near-infinite contrast ratio.
This also adds a Draw Extra Borders editor setting which draws borders around some interactive nodes. This setting is required for good usability of a theme with a fully black background.
Visibility of disabled text (including unselected tab names) has been slightly increased for better accessibility, regardless of the editor theme preset in use.
This closes godotengine/godot-proposals#3368.
Preview
Edit (not shown on the screenshot): Visibility of "disabled" text (such as unselected tab names) has been slightly increased. This applies to any theme preset, not just Black (OLED).