Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against more potential conflicts in C# bindings generator #67440

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

raulsntos
Copy link
Member

This resolves issues such as https://github.com/Gramps/GodotSteam/issues/281 where a module contains members that, due to the conversion to PascalCase, end up conflicting with other members.

Previously we did guard against enums conflicting with properties but in the GodotSteam module there were conflicts between other kinds of members such as methods, signals and constants.

  • Adds check for enums to see if the conflict with methods and signals, not just properties.
    Uses the Enum suffix to avoid the conflict.
  • Adds check for constants to see if the conflict with properties, methods and signals.
    Uses the Constant suffix to avoid the conflict.

@neikeq neikeq merged commit 9afc833 into godotengine:master Oct 16, 2022
@raulsntos raulsntos deleted the dotnet/bindings-conflicts branch October 17, 2022 01:17
@akien-mga akien-mga added this to the 4.0 milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants