Skip to content

Guard against more potential conflicts in C# bindings generator - #67440

Merged
neikeq merged 1 commit into
godotengine:masterfrom
raulsntos:dotnet/bindings-conflicts
Oct 16, 2022
Merged

neikeq merged 1 commit into
godotengine:masterfrom
raulsntos:dotnet/bindings-conflicts

Conversation

@raulsntos

Copy link
Copy Markdown
Member

This resolves issues such as https://github.com/Gramps/GodotSteam/issues/281 where a module contains members that, due to the conversion to PascalCase, end up conflicting with other members.

Previously we did guard against enums conflicting with properties but in the GodotSteam module there were conflicts between other kinds of members such as methods, signals and constants.

  • Adds check for enums to see if the conflict with methods and signals, not just properties.
    Uses the Enum suffix to avoid the conflict.
  • Adds check for constants to see if the conflict with properties, methods and signals.
    Uses the Constant suffix to avoid the conflict.

@neikeq
neikeq merged commit 9afc833 into godotengine:master Oct 16, 2022
@raulsntos
raulsntos deleted the dotnet/bindings-conflicts branch October 17, 2022 01:17
@akien-mga akien-mga added this to the 4.0 milestone Oct 31, 2022
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
…onflicts

Guard against more potential conflicts in C# bindings generator
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
…onflicts

Guard against more potential conflicts in C# bindings generator
wangshucheng pushed a commit to wangshucheng/godot that referenced this pull request Aug 27, 2026
…onflicts

Guard against more potential conflicts in C# bindings generator
Shane-Gadsby pushed a commit to Shane-Gadsby/godotwebgpu that referenced this pull request Sep 21, 2026
…onflicts

Guard against more potential conflicts in C# bindings generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants