Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enter key to add properties to replication editor list #65558

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

the-sink
Copy link
Contributor

@the-sink the-sink commented Sep 9, 2022

Simple usability improvement: allows the ability to use the Enter key while the path input box is in focus to add items to the replication list, as opposed to clicking the "Add from path" button on the right. It will also now reject adding a new item to the list if the input box is empty.

godot.windows.tools.x86_64_2022-09-08_21-40-18.mp4

@timothyqiu
Copy link
Member

I think you can use the text_submitted signal instead of checking for enter yourself in gui_input :)

@YuriSizov YuriSizov requested review from Faless and a team September 9, 2022 12:06
@YuriSizov YuriSizov added this to the 4.x milestone Sep 9, 2022
@the-sink
Copy link
Contributor Author

the-sink commented Sep 9, 2022

I think you can use the text_submitted signal instead of checking for enter yourself in gui_input :)

Ah you're right, forgot about that! Much more straightforward.

@the-sink
Copy link
Contributor Author

Rebased & squashed old commits so this is up-to-date

Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! 👍

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 30, 2023
@akien-mga akien-mga merged commit a0d12cf into godotengine:master Aug 30, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants