Add Placeholder to TextEdit #57100
Merged
Add Placeholder to TextEdit #57100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
reviewed
Jan 23, 2022
| @@ -867,11 +873,14 @@ void TextEdit::_notification(int p_what) { | |||
|
|
|||
| // Ensure we at least use the font color. | |||
| Color current_color = !editable ? font_readonly_color : font_color; | |||
| if (draw_placeholder) { | |||
| current_color.a *= placeholder_alpha; | |||
There was a problem hiding this comment.
I think it would be better to provide it as a dedicated theme color property (that can default to have 0.6 alpha).
There was a problem hiding this comment.
The same is used in the LineEdit, so if it's moved to the theme, it should be done for both.
There was a problem hiding this comment.
Let's do that as a follow-up PR for LineEdit and now TextEdit too.
bruvzg
approved these changes
Jan 24, 2022
| @@ -867,11 +873,14 @@ void TextEdit::_notification(int p_what) { | |||
|
|
|||
| // Ensure we at least use the font color. | |||
| Color current_color = !editable ? font_readonly_color : font_color; | |||
| if (draw_placeholder) { | |||
| current_color.a *= placeholder_alpha; | |||
There was a problem hiding this comment.
The same is used in the LineEdit, so if it's moved to the theme, it should be done for both.
|
Thanks! |
|
Is this backported? |
No, it needs to be redone from scratch in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a placeholder to
TextEditfollowing the same naming scheme inLineEdit. Supports wrapping, newlines and scrolling.Uses the same draw loop thanks to the
TextServerabstractions, though does not appear on the minimap.closes godotengine/godot-proposals/issues/1995