Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize renderer code + cache and threading optimizations. #44838

Merged
merged 3 commits into from
Jan 5, 2021

Conversation

reduz
Copy link
Member

@reduz reduz commented Dec 31, 2020

Some benchmarks.
image

Dynamic Cull clearly needs a better system to do indexing.. the rest of the optimizations seem to have significantly improved performance. Still a good amount of room left to optimize.

@reduz reduz marked this pull request as draft December 31, 2020 12:48
@Calinou Calinou added this to the 4.0 milestone Dec 31, 2020
@reduz reduz force-pushed the renderer-reorganization branch 3 times, most recently from 8335ed4 to a2771fa Compare January 4, 2021 20:14
@reduz reduz marked this pull request as ready for review January 4, 2021 20:15
@reduz reduz force-pushed the renderer-reorganization branch 2 times, most recently from 0e940d9 to afcf438 Compare January 4, 2021 20:58
@akien-mga akien-mga changed the title Reorganize renderer code. Reorganize renderer code + cache and threading optimizations. Jan 5, 2021
So it can hopefully be made more cache efficient afterwards.
-Reorganize thread work pool for rendering
-Fixes to make secondary command buffers to work (disabled because they need more testing)
Copy link
Contributor

@JFonS JFonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over the files and I didn't see anything blatantly wrong, but it wasn't an in-depth review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants