-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize renderer code + cache and threading optimizations. #44838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
Jan 1, 2021
reduz
force-pushed
the
renderer-reorganization
branch
3 times, most recently
from
January 4, 2021 20:14
8335ed4
to
a2771fa
Compare
reduz
force-pushed
the
renderer-reorganization
branch
2 times, most recently
from
January 4, 2021 20:58
0e940d9
to
afcf438
Compare
akien-mga
changed the title
Reorganize renderer code.
Reorganize renderer code + cache and threading optimizations.
Jan 5, 2021
akien-mga
reviewed
Jan 5, 2021
So it can hopefully be made more cache efficient afterwards.
-Reorganize thread work pool for rendering -Fixes to make secondary command buffers to work (disabled because they need more testing)
reduz
force-pushed
the
renderer-reorganization
branch
from
January 5, 2021 11:50
afcf438
to
77bc3e9
Compare
JFonS
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went over the files and I didn't see anything blatantly wrong, but it wasn't an in-depth review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some benchmarks.
Dynamic Cull clearly needs a better system to do indexing.. the rest of the optimizations seem to have significantly improved performance. Still a good amount of room left to optimize.