Cleanup obsolete tests from displaying in help #40832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jul 29, 2020
| @@ -262,25 +262,20 @@ void Main::print_help(const char *p_binary) { | |||
| OS::get_singleton()->print(" -h, --help Display this help message.\n"); | |||
| OS::get_singleton()->print(" --version Display the version string.\n"); | |||
| OS::get_singleton()->print(" -v, --verbose Use verbose stdout mode.\n"); | |||
| OS::get_singleton()->print( | |||
| " --quiet Quiet mode, silences stdout messages. Errors are still displayed.\n"); | |||
| OS::get_singleton()->print(" --quiet Quiet mode, silences stdout messages. Errors are still displayed.\n"); | |||
There was a problem hiding this comment.
This is longer than 120 chars, which is why it was split by black. Why does CI pass?
There was a problem hiding this comment.
Because it's clang-format? 😮
I dunno why it got split though, quite ugly if you ask me, breaks alignment heavily.
There was a problem hiding this comment.
Welp nevermind me. I don't know why those had been split either.
There was a problem hiding this comment.
Looks like it was done by @RevoluPowered in 5793428 who is known for struggling with respecting the style guide :P
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous tests cannot be run with the current doctest runner, so makes sense just to remove the list to prevent confusion.
Some tests still have to be ported as described in #40659.
Let it go. 🙂