Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly orphan polygon index buffer after binding #34088

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Properly orphan polygon index buffer after binding #34088

merged 1 commit into from
Dec 3, 2019

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Dec 3, 2019

Fixes: #34065

Implements @oeleo1's patch from this comment #34065 (comment)

See comment for explanation.

@clayjohn clayjohn added this to the 3.2 milestone Dec 3, 2019
@clayjohn clayjohn requested a review from reduz as a code owner December 3, 2019 15:55
@akien-mga akien-mga merged commit 40d1486 into godotengine:master Dec 3, 2019
@akien-mga
Copy link
Member

Thanks!

@pouleyKetchoupp
Copy link
Contributor

Should we make the same changes in the new method RasterizerCanvasGLES3::_draw_generic_indices introduced in #33857? It's used for Polygon2D & Line2D anti-aliasing.

@akien-mga
Copy link
Member

@pouleyKetchoupp Yes, see #34065 (comment)

@pouleyKetchoupp
Copy link
Contributor

Thanks @akien-mga. I can make a PR tomorrow for this extra fix if nobody does it in the meantime.

akien-mga added a commit to akien-mga/godot that referenced this pull request Dec 4, 2019
@akien-mga
Properly orphan polygon index buffer after binding (take 2)
745a891 
Follow-up to godotengine#34088, patch by @oeleo1 from
godotengine#34065 (comment)
@akien-mga akien-mga mentioned this pull request Dec 4, 2019
Merged
@akien-mga
Copy link
Member

@pouleyKetchoupp Already done with #34099 :)

marstaik pushed a commit to marstaik/godot that referenced this pull request Dec 24, 2019
@akien-mga @marstaik
Properly orphan polygon index buffer after binding (take 2)
ba44e30 
Follow-up to godotengine#34088, patch by @oeleo1 from
godotengine#34065 (comment)
@clayjohn clayjohn deleted the GLES3-polygon-buffer-orphaning-fix branch January 31, 2020 18:15
@lawnjelly lawnjelly mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Random crashes due to GL out of memory
3 participants
@clayjohn @akien-mga @pouleyKetchoupp