Fix memory leaks

[Chaosus]

Closes #17033, #17032, #17031, thanks @fangang190

Im not sure about right way to fix for #17030, cuz im not an expert in android apk, and calling zipClose(unaligned_apk, NULL); before return may cause errors, so anybody with free time and knowledge could fix it instead

[ghost]

Thirdparty bugfix should contain comment // -- GODOT start -- and // -- GODOT end --, a .patch of the change, and the following comment to thirdparty/README.md:

Important: Some files have Godot-made changes. They are marked with // -- GODOT start -- 
and // -- GODOT end -- comments and a patch is provided in the [thirdparty_module]/ folder.

[Chaosus]

Done.. waiting for merge..

[27thLiz]

Did you forget to git add the patches by any chance? They seem to be missing ^^

[Chaosus]

I dont understand you, I just use the commit and then rebase with squash.. and it was enough in most cases

[27thLiz]

Well, what I mean is that you mention the patches in the readme:

Important: Some files have Godot-made changes.
They are marked with // -- GODOT start -- and // -- GODOT end --
comments and a patch is provided in the b2d_convexdecomp/ folder.

But there are no *.patch files in your commit.

[Chaosus]

@Hinsbart Ok, I change it to just

"Important: Some files have Godot-made changes.
They are marked with // -- GODOT start -- and // -- GODOT end --
comments."

[akien-mga]

Won't pCluster leak on line 1297 too if we don't enter this if?

[akien-mga]

Nevermind, it's assigned to m_pUnknownSize and should not be freed.

[Chaosus]

Yeah, I saw it too and didnt decide to delete

[akien-mga]

Thanks! Would you mind contributing those fixes upstream too, so that we can drop our custom modification next time we sync with them?

• b2d_convexdecomp: https://github.com/erincatto/Box2D/blob/master/Contributions/Utilities/ConvexDecomposition/b2Polygon.cpp#L1340
• Etc2comp: https://github.com/google/etc2comp/blob/master/EtcLib/Etc/EtcFilter.cpp#L229-L232
• libwebm: That's Google, no clue how to send a PR, so maybe leave that one..

[Chaosus]

Okay ) I take a look on it

[Chaosus]

@akien-mga Seems like erincato merged my PR to b2Polygon - erincatto/box2d#486,
I think the part of this PR should be reverted and b2Polygon should be updated

[akien-mga]

Thanks for the notice. It looks like we already had quite a few changes compared to the upstream code (diff when trying to replace our files by upstream ones: https://paste.fedoraproject.org/paste/-5ujnPQIUTZFZI8IjhhB2A), so I guess it's good to keep as is.

Some of our changes shown in the diff are cosmetic and could be pushed upstream, but others are specific to Godot (like removing the dependency on Box2D's glue and using some Godot constants like CMP_EPSILON, or adding a namespace and removing debug spam).