Fix regression in moving resources in filesystem dock #102493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
approved these changes
Feb 6, 2025
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Feb 7, 2025
…egression Fix regression in moving resources in filesystem dock
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was introduced in #101616, but it breaks moving of resources, since it disallows the logic in
__update_resource_paths_after_move().test_proj.zip
To reproduce the issue, open the scene and the script, then move the script twice, in and out of the additional dir. Errors will appear and the script will be detached on the second move.