Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OS.request_permission(...) description #100785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

syntaxerror247
Copy link
Contributor

This PR corrects the long-standing incorrect description of OS.request_permission. This method was updated in PR #77686, but its description was not revised to reflect the changes.

@syntaxerror247 syntaxerror247 requested a review from a team as a code owner December 24, 2024 11:43
@syntaxerror247
Copy link
Contributor Author

@m4gr3d Could you please review and confirm if it correctly reflects the intended behaviour?

@Mickeon Mickeon added this to the 4.4 milestone Dec 24, 2024
@Mickeon Mickeon requested a review from a team December 24, 2024 12:08
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

The link to MainLoop.on_request_permissions_result is particularly nice, because it's quite surprising that the signal is on a different object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants