Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when duplicating Decal or Light3D nodes #100632

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Namey5
Copy link
Contributor

@Namey5 Namey5 commented Dec 20, 2024

Crash was caused by duplicating Node properties generically with no textures assigned to the Decal triggering a null-deref in some validation code.

Change in code style was by clang-format.

Fixes #100629

@Namey5 Namey5 requested a review from a team as a code owner December 20, 2024 04:54
@YeldhamDev YeldhamDev added this to the 4.4 milestone Dec 20, 2024
@akien-mga
Copy link
Member

akien-mga commented Dec 20, 2024

I fixed up the clang-format issue to respect the original intent :)

clang-format just needs knowing how to talk to it :P

image

Co-authored-by: Jayden Sipe <jayden.sipe@gmail.com>
@akien-mga akien-mga force-pushed the decal-duplication-crash branch from 8fc1e87 to 90a0c06 Compare December 20, 2024 22:52
@akien-mga akien-mga changed the title Fix crash when duplicating Decal node Fix crash when duplicating Decal or Light3D nodes Dec 20, 2024
@akien-mga
Copy link
Member

I amended @jaydensipe's #100639 in this commit as the two changes are related, so it makes sense to merge them together as a single commit. And so I added @jaydensipe as co-author here.

@akien-mga akien-mga merged commit 024b6bc into godotengine:master Dec 20, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks @Namey5 and @jaydensipe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicating a Decal (or Light3D) node crashes Godot
4 participants