Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking outside popup in single window mode will pass the event #94930

Open
KoBeWi opened this issue Jul 29, 2024 · 2 comments
Open

Clicking outside popup in single window mode will pass the event #94930

KoBeWi opened this issue Jul 29, 2024 · 2 comments

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jul 29, 2024

Tested versions

4.3 rc1 and earlier

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

When you run editor in single window mode and click outside a popup to close it, the popup is closed, but the event is passed further.
In multi window mode closing the popup by clicking outside will block the event from propagating further.

This inconsistency caused #93718

Steps to reproduce

  1. Open editor in any window mode
  2. Open a popup menu
  3. Click a node in 2D editor while the popup is open
  4. Repeat the steps with other window mode and compare results

Minimal reproduction project (MRP)

N/A

@Giganzo
Copy link
Contributor

Giganzo commented Jul 29, 2024

Does popup include the tooltips?
It's a bit annoying that they eat clicks when you want to click on the revert button, as you often have to click on the revert button twice to reset the property.

Edit: yes, applies to tooltips as well.

@Jowan-Spooner
Copy link

I came across this behavior recently and wished there was a way to configure this manually, per popup, because I actually wanted a pop-up in multi-window mode (in an application, not the godot editor) to close but NOT consume the event, even though I'm not sure if that's even possible (but sounds like it could be useful for tooltips too).
Doubt this is in scope of a fix PR though 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants