Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows input: Editor livelock when alt-tab while right mouse is pressed. #92306

Closed
lyuma opened this issue May 24, 2024 · 3 comments
Closed

Comments

@lyuma
Copy link
Contributor

lyuma commented May 24, 2024

Tested versions

  • Reproducible in 4.2.1
  • Reproducible in 4.3.beta bd2300d

System information

Godot v4.3.beta (bd2300d) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; 31.0.15.3713) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)

Issue description

When the editor is defocused while the mouse is captured due to right click drag in 3D, if the editor pops up an alert, the user will be unable to acknowledge the alert due to mouse being captured by the underneath editor window, but unable to focus the editor window due to the alert.

I show how to escape this in the video but it is extremely difficult and most users will probably be forced to kill godot.

godot_bug_alt_tab_livelock.mp4

Unlike other issues I filed today, this is not a new bug, but it is made far more common due to issues such as #92304

Steps to reproduce

  1. Open two copies of the editor in the same project so that Godot pops up a Please Confirm...newer on disk popup. Click Cncel.
  2. Hold right mouse button
  3. Alt+Tab
  4. re-focus the godot editor.
  5. The mouse will be captured but there will be a Please Confirm popup on top, but the mouse cannot move.
  6. To escape, use another window to position the mouse on top of the cancel button of the blocking dialog, then click left button. Sometimes this is not enough: it might be necessary to press enter while the mouse is held.

Minimal reproduction project (MRP)

Reproduces in empty project.

@SaracenOne
Copy link
Member

@bruvzg As posted on the other similar issue, you might want to look at 12fda2f. While I can't be 100% certain this is it, after a fair amount of bisecting, I'm beginning to reckon this might have caused a regression.

@akien-mga akien-mga changed the title windows input: Editor livelock when alt-tab while right mouse is pressed. Windows input: Editor livelock when alt-tab while right mouse is pressed. May 24, 2024
@matheusmdx
Copy link
Contributor

I tested this issue in 4.0.4.stable (works normal), v4.1.beta1.official [828ec2c] (broken) and latest master v4.3.beta.custom_build [be56cab] (broken) and bisecting points to #69318 as the culprit:

Captura 2024-05-27 08-06-18-486864

Also when the bug happens, you can press alt+f4 that will close the popup, after that press the right mouse button and the mouse will appear again

@matheusmdx
Copy link
Contributor

Tested latest master (96a386f) and #92424 already fixed this issue

image

@KoBeWi KoBeWi closed this as completed Aug 20, 2024
@KoBeWi KoBeWi added this to the 4.3 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants