Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3Dev6,Beta1]Bones that are not bound to PhysicalBone3D will not follow the movement of their parent bones #91606

Closed
dszhblx opened this issue May 6, 2024 · 5 comments · Fixed by #92931

Comments

@dszhblx
Copy link

dszhblx commented May 6, 2024

Tested versions

Reproducible in 4.3dev6, 4.3beta1
Not reproducible in 4.3dev5, 4.3dev4

System information

Windows 10

Issue description

In 4.3dev6,Bones that are not bound to PhysicalBone3D will not follow the movement of their parent bones.
[Considering that people have many fingers and toes, including joints, if you bind PhysicalBone3D to each bone, it will be difficult to operate and adjust.I believe the approach in previous godot versions was correct]
In addition, the 'Create Physical Skeleton' function in the menu does not generate PhysicalBone3D bindings for end bones, including heads, feet, and fingers.
dev6

In previous Godot versions, Bones that are not bound to PhysicalBone3D will follow the movement of their parent bones.
dev5

Steps to reproduce

1.Open testbones_dev5.zip using Godot 4.3 Dev5,Run,wait 1 second
2.Open testbones_dev6.zip using Godot 4.3 Dev6,Run,wait 1 second
3.Compare the differences between the two

Minimal reproduction project (MRP)

testbones_dev5.zip
testbones_dev6.zip

@dszhblx
Copy link
Author

dszhblx commented Jun 1, 2024

@Sauermann Godot 4.3 beta1 also has this problem.
Will the official version 4.3 fix this problem?

@AThousandShips
Copy link
Member

Hopefully, but no one has picked it up yet, pinpointing what changes caused this would help a lot, so bisecting the bug would be useful

@dszhblx
Copy link
Author

dszhblx commented Jun 1, 2024

Hopefully, but no one has picked it up yet, pinpointing what changes caused this would help a lot, so bisecting the bug would be useful

Thank you for your quick reply. There is no assignee for this question for three weeks.

@dszhblx dszhblx changed the title [4.3Dev6]Bones that are not bound to PhysicalBone3D will not follow the movement of their parent bones [4.3Dev6,Beta1]Bones that are not bound to PhysicalBone3D will not follow the movement of their parent bones Jun 1, 2024
@matheusmdx
Copy link
Contributor

Bisecting points to #87888 as the culprit:

Captura 2024-06-05 02-32-55-918572

@dszhblx
Copy link
Author

dszhblx commented Jun 21, 2024

Godot 4.3 beta2 fixed this bug.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

Successfully merging a pull request may close this issue.

5 participants