-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web build fails on Emscripten 3.1.58 #91161
Comments
The regression comes from 3.1.58 itself, I built successfully with 3.1.57. This change sounds pretty relevant:
https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md#3158---042324 |
I wonder if/when we could bump to 3.1.58 as the minimum version and do some cleanup in our threaded load/export paths. |
Seems like the issue is caused by a bug upstream fixed via emscripten-core/emscripten#21830 (which will be in |
Thanks for checking! This is a wontfix then, as there's little point trying to workaround a bug only present in one release. We can still fix the warnings as you've started doing though. There's also this one that might be worth a look:
|
Tested versions
System information
Fedora Linux 39 (KDE Plasma) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7600M XT (RADV NAVI33) () - AMD Ryzen 7 7840HS w/ Radeon 780M Graphics (16 Threads)
Issue description
Emscripten never fails to disappoint with breaking Godot every other release.
I tested the latest 3.1.58 and our Web editor build is broken (this is with closure compiler, but it fails the same without).
The missing
godot.web.editor.wasm32.worker.js
is actually generated in the root folder of the repo, instead of thebin
folder.It works fine with Emscripten 3.1.39, so it regressed somewhere in between.
Steps to reproduce
scons p=web target=editor
Minimal reproduction project (MRP)
n/a
The text was updated successfully, but these errors were encountered: