Popup with container and autowrap Label doesn't sort properly

[nathanfranke]

Godot version

v4.2.beta1.official [b137180]

System information

Arch on 6.5.7-arch1-1

Issue description

I'm not sure exactly what the issue is, but easy to reproduce.

Even in the project manager, this window is much bigger in 4.2.beta1 than 4.1.2.stable.

In both cases the increased height is the Label wrapping with a width of zero.

Closing and re-opening the popup works around the issue.

4.1.2:

4.2.beta1:

Steps to reproduce

Launch MRP in 4.2.beta1+ or click an outdated project in the project manager.

Minimal reproduction project

test7-sizing.zip

extends Node

func _ready() -> void:
	var dialog := AcceptDialog.new()
	dialog.name = "AcceptDialog"
	add_child(dialog)
	
	var container := PanelContainer.new()
	container.custom_minimum_size.x = 200.0 # Not necessary for reproducing.
	dialog.add_child(container)
	
	var label := Label.new()
	label.autowrap_mode = TextServer.AUTOWRAP_WORD_SMART
	label.text = "a b c d e f"
	container.add_child(label)
	
	dialog.popup_centered()

[nathanfranke]

Related to #47005, #76000

But there seems to be a regression newer than either of those issues.

[KaddieZ]

Can confirm this bug in 4.2-beta1_mono, just happened to reproduce it while testing out GraphNode, a Label will break the height calculation of the GraphNode as soon as Autowrap (any mode) is activated.

In this picture, first node has no Autowrap. All the others are Autowrap Word Smart. Height of GraphNode seems to depends on the number of words in the label somehow.

Important note: height calculation works fine in the godot editor, only breaks while in-game.
Height calculation in the godot editor seems to work fine until you reload the project and the size is now broken the same in the editor as in game. Bottom anchor offset can be manually fixed but wont register.

Edit : here's the project I made to test this label_wrap_bug.zip

[akien-mga]

I can confirm the bug with the two MRPs in this issue.

It seems to have been introduced in 4.2-dev3 (4.2-dev2 behaves like 4.1.2-stable).

If someone wants to bisect further between dev2 and dev3, that would be very useful.

[nathanfranke]

I bisected to b156e24, #77280
CC @Rindbee

git checkout df616c9a17dfd9e5248c8fdebe20bd192f95266f # good
git checkout b156e24216f81aefcbc4f7983cdb7c6515d7ac76 # bad

[Rindbee]

Seems similar to #80218.
#83546 (comment) seems similar to #74052.

[YuriSizov]

See my exhaustive comment here #80218 (comment). This is not something we can currently fix at its core. You should ensure your labels have at least some reasonable minimum size, and everything should work correctly. For editor widgets we should add minimum sizes where they are required as well.

[Rindbee]

In case of autowrap_mode != TextServer::AUTOWRAP_OFF. Maybe we can use the following code based on the fact that Label::_shape() bases on width and the default initial width is 0, to avoid giving an excessively large minimum height when width is undetermined.

 Size2 Label::get_minimum_size() const {
+       if (autowrap_mode != TextServer::AUTOWRAP_OFF && get_size() == Size2()) {
+               return Size2(); 
+       }
+

[YuriSizov]

The behavior of the label is technically correct, so this isn't really a good solution. In any case, I wouldn't touch it at all right now. Because of the underlying issues every time we touch these nodes, we risk multiple regressions. The problem is documented, it's fine for the release in this state. This is better than introducing potential and unknown issues without any time to test everything.

[akien-mga]

#84662 adds a node configuration warning for Labels using autowrap in containers, to make users aware that this is not a stable setting unless a custom minimum size is specified.

So this alleviates the problem for 4.2, until we can rework the sizing logic to follow a better approach.

[nathanfranke]

This also works around the MRP:

label.set_anchors_and_offsets_preset(Control.PRESET_TOP_WIDE)

Slightly cleaner than set_custom_minimum_size IMO, but still needs an explanatory comment.