Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspector sections with big custom icons don't shrink properly #82527

Closed
KoBeWi opened this issue Sep 29, 2023 · 0 comments · Fixed by #82540
Closed

Inspector sections with big custom icons don't shrink properly #82527

KoBeWi opened this issue Sep 29, 2023 · 0 comments · Fixed by #82540
Labels
bug topic:editor usability
Milestone
4.2

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Sep 29, 2023

Godot version

4.2 dev5

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

@icon("res://icon.svg")
extends Node2D

@export var test: int
godot.windows.editor.dev.x86_64_vBS9vYCEwk.mp4

The section seems to have the height of the full icon before it was resized.

Steps to reproduce

  1. Put the code above in a node
  2. Close and open scene tab
  3. Click the node
  4. Switch to Node tab and back

Minimal reproduction project

N/A
@YuriSizov YuriSizov added this to the 4.x milestone Sep 29, 2023
@jackwilsdon jackwilsdon mentioned this issue Sep 29, 2023
Merged
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Sep 30, 2023
mandryskowski pushed a commit to mandryskowski/godot that referenced this issue Oct 11, 2023
@jackwilsdon @mandryskowski
Use theme icon size when calculating category minimum size
4c869ce 
This previously used the underlying size of the icon, causing the
category to grow incorrectly when re-rendered.

Fixes godotengine#82527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Use theme icon size when calculating category minimum size jackwilsdon/godot
3 participants
@KoBeWi @akien-mga @YuriSizov