We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.2.dev.custom_build.ba54c3455
macOS M1
In cowdata.h line 314:
cowdata.h
godot/core/templates/cowdata.h
Line 314 in 571cd0e
We can see:
*_get_size() = p_size;
The function _get_size() may return nullptr:
_get_size()
_FORCE_INLINE_ uint32_t *_get_size() const { if (!_ptr) { return nullptr; } return reinterpret_cast<uint32_t *>(_ptr) - 1; }
I discovered this when investigating the issue: #63534
This is the cause of the issue and the cause of the crash.
Since I don't understand Copy-On-Write logic, I don't know how to fix it. So I leave it to you guys.
res://godot_4_alpha_12_tileset_issue_2.log
Get #63534 project (download the example)
The text was updated successfully, but these errors were encountered:
I'm not sure how this could happen as all the paths leading to *_get_size() = p_size; are null checked?
Sorry, something went wrong.
Might know, will do some checking later today
I did small change to see the result of _get_size() and indeed it's zero-pointer:
I've identified the error, looking into a fix
CowData
AThousandShips
Successfully merging a pull request may close this issue.
Godot version
v4.2.dev.custom_build.ba54c3455
System information
macOS M1
Issue description
In
cowdata.h
line 314:godot/core/templates/cowdata.h
Line 314 in 571cd0e
We can see:
*_get_size() = p_size;
The function
_get_size()
may return nullptr:I discovered this when investigating the issue: #63534
This is the cause of the issue and the cause of the crash.
Since I don't understand Copy-On-Write logic, I don't know how to fix it. So I leave it to you guys.
Steps to reproduce
res://godot_4_alpha_12_tileset_issue_2.log
Minimal reproduction project
Get #63534 project (download the example)
The text was updated successfully, but these errors were encountered: