-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AudioStream preview filenames use different color and size from the rest of the inspector #75670
Comments
It looks like the same font to me, but at a different size. I don't see any immediate issue in the code, but it does use a Label font and font size, which indirectly should still go to the main font and main font size from the settings. What do you expect it to look like? |
I'd expect it to look just like the other text that's used everywhere else (in the screenshot, the smaller, thinner text). Being so large/bold is not only jarring, but you can't see as much of the filename either. It "looks like" a bug - like someone forgot to make the label follow the style guidelines or something. |
The file name uses a different font size and color, which is unexpected. It is indeed an intentional override. This is with the default font and default font size settings: The overrides are performed here and were added by #63265: godot/editor/editor_resource_picker.cpp Lines 1117 to 1211 in ef02571
Feel free to play around with them if you can make them look better 🙂 |
As I mentioned, while it refers to the label properties, those fall back onto the main font and the main font size values. Label doesn't have a font size defined in the editor theme, and it uses the configured main font as its font. It is possible, that due to the font size missing in the label definition that instead of falling back onto the main font size it falls back onto the default theme font size. This needs to be tested. I don't think that the override was deliberate necessarily. |
Godot version
4.0.2
System information
Windows 11
Issue description
I changed the "Main Font" and "Main Font Bold" in the Editor Settings.
I have a script that's @exporting an Audio Stream, and an array of AudioStreams.
When I drag files into the Inspector to populate those @exports, the filenames aren't using the font settings I assigned.
Steps to reproduce
Minimal reproduction project
(You'll have to change your Fonts in Editor Settings to see the issue.)
wrong_fonts.zip
The text was updated successfully, but these errors were encountered: