Godot errors/crashes after inspecting two different objects handled by the same plugin

[Zylann]

Godot version

Godot 4 rc2

System information

Windows 10 64 bits NVIDIA GeForce GTX 1060

Issue description

I was trying to reproduce a nasty error I started having since stuff got changed in some areas of editor plugins, but in RC2 instead of reproducing my issue, I ended up finding this crash. So I thought I'd report it...

I wrote a simple test plugin that adds a bottom panel with two buttons:

• "Edit Sprite": edits the last selected sprite
• "Edit Texture": edits the texture of the last selected sprite

This plugin handles BOTH Sprite2D and Texture2D.

Steps to reproduce

After testing the plugin a bit, I turned it off, then clicked on the Script tab: Godot crashes. No information popup or logs, just shuts down.

Minimal reproduction project

EditorPluginEditAnotherHandled.zip

This project has the plugin enabled by default.

• Open the main scene and go to the 2D view
• Select the sprite
• In the bottom bar, click "Test plugin" to show the custom panel
• In the custom panel, click "Edit Texture" and "Edit Sprite" alternatively a bunch of times
• Go to Project Settings and turn off the plugin: Godot might crash already.
• If no crash occurred, click on the "Script" tab: observe crash.

Secondary note:
I was told that one of the changes to EditorPlugin was that _edit(null) can be called when "there is no longer any selected object handled by this plugin" (seen in the doc). But if you look in the console while alternating the two buttons (which ask the editor to inspect two different objects handled by the plugin), you will notice that edit(null) occurs half of the time, I dont understand why.

Third note:
When testing this repro in master 9c960a8, if I select the sprite and then click on the "Edit Texture" button, I get an error:

ERROR: Condition "plugins_list.has(p_plugin)" is true.
   at: EditorPluginList::add_plugin (editor\editor_node.cpp:8119)

Which I dont understand either.

[KoBeWi]

if I select the sprite and then click on the "Edit Texture" button, I get an error:

#73512 (comment)

[Zylann]

Yet another note after seeing this suggestion #40166 (comment):
If I provide true as the last argument of inspect_object, which the doc describes as:

If inspector_only is true, plugins will not attempt to edit object.

Then my plugin's UI gets closed, as EditorNode::push_item still calls _edit_current and then make_visible(false) and edit(null). It didn't use to do that (in fact that was the point of it, seems?). This might have been a workaround since I saw other plugins inspect "sub-objects" to allow users to edit them via the inspector usin this boolean, but I had no luck trying that, I dont understand this option...

I searched how the VisualShaderEditorPlugin handles editing sub-resources inside nodes with the inspector, without getting bothered, and it uses InspectorDock::get_inspector_singleton()->edit(p_resource.ptr());, which is not available to scripts.

[AttackButton]

I got a similar bug today, the engine sunddely crashes when I click on the TileMap node. =/

ERROR: The TileSetAtlasSource atlas has no tile at (2, 1).
at: (scene\resources\tile_set.cpp:4515)
ERROR: Condition "plugins_list.has(p_plugin)" is true.
at: EditorPluginList::add_plugin (editor\editor_node.cpp:8152)

[dandeliondino]

I am also getting plugins_list.has(p_plugin) errors with a TileSet editor inspector plugin. I'm having difficulty pinpointing what's causing it because my code isn't doing anything at the time the error occurs. The error appears when a user opens the TileSet bottom editor. I have placed a persistent helper node under base_control, but the plugin script doesn't return true from _can_handle() until it reaches AtlasTileProxyObject, which is after the error occurs.

In my case, the error is not associated with crashes or any other obvious problems.

[dandeliondino]

Never mind! A new project with no plugins still prints this error when opening the TileSet editor, so it's coming from the engine itself.

editor/editor_node.cpp:8152 - Condition "plugins_list.has(p_plugin)" is true.

[Kregap]

I'm seeing the same error after doing tile set/map for a moment. Using Godot v4.0.stable.official [92bee43]. No plugins added to the project.