Export categories from parent classes are not reloading, and cause "duplicate categories".

[Frontrider]

Godot version

4.0 beta 13

System information

Manjaro Linux

Issue description

Export categories from the parent script are not shown unless you reload the project, and can cause the same category name to be duplicated.

The first one is a bug, that needs to be fixed. Categories shouldn't just vanish like that.

The second one is a thing I can't place, personally I'd expect those to be merged instead of getting 2 menus with the same name.

Steps to reproduce

If you extend this script:

extends CharacterBody2D
class_name Speed

@export_category("speed")
@export var speed:int = 1.0:
	set(new_value):
		speed = new_value
	get:
		if(parent_segment != null):
			return parent_segment.speed
		return speed

With this:

extends Speed

@export_category("speed")
@export var turn_speed = 10

Then at first you won't see the category from the parent class, then after a project reload you'll see 2 categories with the name "speed".

Minimal reproduction project

N/A

[KoBeWi]

It might be related to other script reloading issues. Strange that reloading scene does not help; it usually works.

The second one is a thing I can't place, personally I'd expect those to be merged instead of getting 2 menus with the same name.

The properties are grouped by class first and then by category. That's how inspector is designed; it does not support merging categories between classes.

[Frontrider]

The properties are grouped by class first and then by category. That's how inspector is designed; it does not support merging categories between classes.

Taking that as the answer, but it is something that at least looks like a bug. Someone else will inevitably report it as a bug if left like this.

[YuriSizov]

Categories are not supposed to be used like this at all. They are exposed for your convenience, but categories are designed to represent the class hierarchy. Groups should be used for grouping, and groups only exist within categories. We simply do not recommend using categories frivolously. Also, the list of properties is linear, what you see if what you get, exactly in that order, and respecting the class hierarchy. And that's what we'll say to a potential bug report.

[vnen]

@YuriSizov is there anything we can do about this? Potentially we could check for a probable misuse of the feature, but all in all it seems to be working as intended.

[Frontrider]

Can you show an error if the group was duplicated? I think that should be more than enough to "enforce the correct usage", and not have anyone mention it again. :)

[YuriSizov]

We could add a warning if you try to add a category or a (sub)group with the same signature, but otherwise indeed this is working as intended and grouping properties can be duplicated without any repercussions. You just shouldn't expect them to merge.

I guess a warning would be like "child category is shadowing parent category, pay attention"? May want to wait a bit and see if there is a lot of confusion, or if it's just this one report.

[Frontrider]

I guess a warning would be like "child category is shadowing parent category, pay attention"? May want to wait a bit and see if there is a lot of confusion, or of it's just this one report.

That would be perfect. After the explanation the only issue I see here is that it looks like a bug.

[dalexeev]

This needs to be re-tested, maybe something has changed after #78254 and #81221.

[KoBeWi]

Then at first you won't see the category from the parent class, then after a project reload you'll see 2 categories with the name "speed".

The double category shows immediately now

[dalexeev]

Export categories from the parent script are not shown unless you reload the project, and can cause the same category name to be duplicated.

The first one is a bug, that needs to be fixed. Categories shouldn't just vanish like that.

It might be related to other script reloading issues. Strange that reloading scene does not help; it usually works.

The double category shows immediately now

I think the first part regarding script reloading has been fixed, probably by #83123.

The second one is a thing I can't place, personally I'd expect those to be merged instead of getting 2 menus with the same name.

The properties are grouped by class first and then by category. That's how inspector is designed; it does not support merging categories between classes.

I think after a number of PRs this now works properly and categories/groups/subgroups don't conflict with each other and regular properties:

• GDScript: Fix conflict between property and group names #78254
• Editor: Inspector and Signal docks improvements #81221
• Editor: Fix _parse_category() is not called for custom categories #87915
• Editor: Fix skipping normal category followed by custom one #88318
• Editor: Fix same-name (sub)groups interfering in Inspector #89631

is there anything we can do about this? Potentially we could check for a probable misuse of the feature, but all in all it seems to be working as intended.

Can you show an error if the group was duplicated?

We could add a warning if you try to add a category or a (sub)group with the same signature, but otherwise indeed this is working as intended and grouping properties can be duplicated without any repercussions.

I guess a warning would be like "child category is shadowing parent category, pay attention"?

I think this is no longer necessary since you can now have categories/groups/subgroups duplicated at different inheritance levels.

So, if there is no objection, I suggest closing this issue after merging #89631.

[Frontrider]

IF nobody has anything else to add, close it.