Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to themes that a control indirectly inherit items from don't cause the control to update #62844

Closed
AaronRecord opened this issue Jul 8, 2022 · 2 comments · Fixed by #62845
Closed

Changes to themes that a control indirectly inherit items from don't cause the control to update #62844

AaronRecord opened this issue Jul 8, 2022 · 2 comments · Fixed by #62845
Labels
bug confirmed topic:gui
Milestone
4.0

Comments

@AaronRecord
Copy link
Contributor

AaronRecord commented Jul 8, 2022 •
edited
Loading

Godot version

3.4.4

System information

Windows 11

Issue description

2022-07-08.13-55-38.mp4

See also #61765
See also #63889

Steps to reproduce

^^

Minimal reproduction project

mrp.zip
@AaronRecord AaronRecord changed the title Changes to themes that Control's inherit items from don't cause the control to update Changes to themes that controls inherit items from don't cause the control to update Jul 8, 2022
@AaronRecord AaronRecord changed the title Changes to themes that controls inherit items from don't cause the control to update Changes to themes that a control inherit items from don't cause the control to update Jul 8, 2022
@AaronRecord AaronRecord changed the title Changes to themes that a control inherit items from don't cause the control to update Changes to themes that a control indirectly inherit items from don't cause the control to update Jul 8, 2022
@AaronRecord AaronRecord mentioned this issue Jul 8, 2022
Merged
@AaronRecord AaronRecord mentioned this issue Jul 27, 2022
Closed
@YuriSizov
Copy link
Contributor

I'd probably split this issue in two. The issue about indirect dependency inside of the tree is solved by #62845, but the issue with project theme/default theme changing would likely require some different solution.

@AaronRecord AaronRecord mentioned this issue Aug 3, 2022
Closed
@AaronRecord
Copy link
Contributor Author

Opened a new issue #63889

@akien-mga akien-mga added this to the 4.0 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Refactor and remove excessive calls of NOTIFICATION_THEME_CHANGED AaronRecord/godot
4 participants
@Calinou @akien-mga @YuriSizov @AaronRecord