Add an editor keyboard shortcut to the C# "Build solution" button

[JimArtificer]

Godot version: 3.2.1
OS/device including version: Windows 10
Issue description: Editor > Editor Settings > Shortcuts does not have a binding for the Build solution button.

This is a workflow concern when editing C# code.

[Calinou]

What should the default shortcut be? We should probably define one while we're at it.

[Flavelius]

Rider uses ctrl-shift-b which sounds reasonable.

[akien-mga]

Something with B indeed sounds good, but it will likely conflict with existing bookmark/breakpoint shortcuts in the script text editor.

[JimArtificer]

Even if this shipped without a default it would address the workflow issue. I expect a lot of people to remap it to F6 anyway (Visual Studio muscle memory).

[codecat]

Was this issue addressed in 3.4 or 4.0 yet? If not I wouldn't mind doing a pull request for this.

[Calinou]

It wasn't added yet - feel free to open a pull request for this 🙂

The Mono editor code is written in C#, so creating a shortcut that can be reassigned in the Editor Settings may not be trivial. Perhaps doing it in C++ may be a better idea.

[codecat]

I underestimated the build requirements for the Mono build of Godot, so I'm gonna have to retract my statement of doing a pull request, sorry. Open for anyone to do this!

[lewiji]

Hi, I was linked to this issue after asking about the same thing.

I've implemented an editor keyboard shortcut for the "Build" button by exposing the ED_GET_SHORTCUT function from editor_internal_calls.cpp via GDMonoUtils::add_internal_call. Result:

However, since I'm working on 3.x, I made this change on a 3.x branch. When I tried to rebase on master, first I got an error because ShortCut from 3.x is now Shortcut in 4 I guess, but now I'm getting further errors unrelated to my changes in code_completion.cpp (unchanged)

Is there an accepted way to submit a PR for 3.x, or do they need to be based on master to be accepted?