Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File explorer Window is wrapped when clicking Browse in import dailog, missing icons and unable to import projects. #37401

Closed
3 tasks done
Tracked by #37734
Anutrix opened this issue Mar 29, 2020 · 4 comments

Comments

@Anutrix
Copy link
Contributor

Anutrix commented Mar 29, 2020

Godot version:
master build fafb0ba

OS/device including version:
Window 10

Issue description:

  • Issue 1: File explorer Window is wrapped when clicking Browse in import dialog.
  • Issue 2: Resizing to see file list also reveals that icons for files and folders are missing.
  • Issue 3: Import .project files does not open project.

I made a single issue since they seem related.

ERROR: Condition "!windows.has(p_window)" is true.
   at: window_resize (drivers\vulkan\vulkan_context.cpp:722)

is also seen in the console every time I interact with a window such as opening a folder or changing drive.

Steps to reproduce:

  1. Open Godot.
  2. Click Import.
  3. Click Browse. - Issue 1 is observed.
  4. Resize to seem files. - Issue 2 is observed.
  5. Select any .project file to import. - Issue 3 is observed.
@Anutrix Anutrix changed the title File explorer Window is wrapped when clicking Browse in import dailog, missing icons and not opening projects. File explorer Window is wrapped when clicking Browse in import dailog, missing icons and unable to import projects. Apr 1, 2020
@Anutrix
Copy link
Contributor Author

Anutrix commented Apr 4, 2020

When popups weren't Windows(pre-441f1a5), they used to be x%(I think 80)/similar of the height and width of the parent window. In other words, they were dependent on parent windows.
But now since they are independent, they use min-height and min-width leading to things like Trees which don't have min size by default to shrunk to size 0. This is the reason for Issue 1.

@Calinou Calinou added this to the 4.0 milestone Apr 4, 2020
@CNate
Copy link

CNate commented Apr 7, 2020

The Vulkan layers can be fixed by installing the latest Vulkan SDK. I am also encountering the resizing error on top of a few other things
image

@Calinou
Copy link
Member

Calinou commented Apr 19, 2020

For the record, this also occurs with the Quick Open dialogs:

Quick Open Scene dialog

@akien-mga
Copy link
Member

Issue 3 should be fixed by #39993 which supersedes #39145, so all issues are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants