Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some shortcuts are hard-coded in TextEdit #29490

Closed
KoBeWi opened this issue Jun 4, 2019 · 2 comments · Fixed by #43663
Closed

Some shortcuts are hard-coded in TextEdit #29490

KoBeWi opened this issue Jun 4, 2019 · 2 comments · Fixed by #43663

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jun 4, 2019

Godot version:
3.1.1

Issue description:
I remember seeing similar issue (maybe), but can't find it now. Anyways, I was looking how #27164 could be implemented and thought that it would make sense if MenuButton shortcuts allowed for echo events. Not all of course, but for stuff like moving or duplicating lines that would be useful.

Then I noticed that some actions, like undo or paste, already support that. Tracking down the code, these actions are hard-coded in TextEdit. There are few problems with that. We can already remap actions like paste to another shortcut and it changes in script editor menu (but not the right-click menu of TextEdit, which is part of script editor). But doing this, we end up with 2 shortcuts for the same action, with one of them working as intended and the new one not supporting continuous actions.

So these actions should somehow be changed to proper shortcuts and also shortcuts should support optional echo events, so everything works the same, but is cleaner and allows improving other actions with continuous activation.

@Paulb23
Copy link
Member

Paulb23 commented Jun 6, 2019

I think you're looking for #12164?

@KoBeWi
Copy link
Member Author

KoBeWi commented Jun 7, 2019

No, I think it was a different one. Still, it didn't had the echo part, so even if similar issue exists, it's not exact duplicate.

EDIT:
It could be this: #17927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment