Skip to content

Commit 7fa4416

Browse files
committed
Use human-readable unique names for GraphEdit's internal nodes
1 parent 96cdbbe commit 7fa4416

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

scene/gui/graph_edit.cpp

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2890,6 +2890,7 @@ GraphEdit::GraphEdit() {
28902890
panner->set_callbacks(callable_mp(this, &GraphEdit::_pan_callback), callable_mp(this, &GraphEdit::_zoom_callback));
28912891

28922892
top_layer = memnew(Control);
2893+
top_layer->set_name("_top_layer");
28932894
add_child(top_layer, false, INTERNAL_MODE_BACK);
28942895
top_layer->set_mouse_filter(MOUSE_FILTER_IGNORE);
28952896
top_layer->set_anchors_and_offsets_preset(Control::PRESET_FULL_RECT);
@@ -2942,11 +2943,13 @@ GraphEdit::GraphEdit() {
29422943
menu_panel->set_position(Vector2(10, 10));
29432944

29442945
menu_hbox = memnew(HBoxContainer);
2946+
menu_hbox->set_name("_menu_hbox");
29452947
menu_panel->add_child(menu_hbox);
29462948

29472949
// Zoom label and controls.
29482950

29492951
zoom_label = memnew(Label);
2952+
zoom_label->set_name("_zoom_label");
29502953
zoom_label->set_visible(show_zoom_label);
29512954
zoom_label->set_v_size_flags(Control::SIZE_SHRINK_CENTER);
29522955
zoom_label->set_horizontal_alignment(HORIZONTAL_ALIGNMENT_CENTER);
@@ -2955,6 +2958,7 @@ GraphEdit::GraphEdit() {
29552958
_update_zoom_label();
29562959

29572960
zoom_minus_button = memnew(Button);
2961+
zoom_minus_button->set_name("_zoom_minus_button");
29582962
zoom_minus_button->set_theme_type_variation(SceneStringName(FlatButton));
29592963
zoom_minus_button->set_visible(show_zoom_buttons);
29602964
zoom_minus_button->set_tooltip_text(ETR("Zoom Out"));
@@ -2963,6 +2967,7 @@ GraphEdit::GraphEdit() {
29632967
zoom_minus_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_zoom_minus));
29642968

29652969
zoom_reset_button = memnew(Button);
2970+
zoom_reset_button->set_name("_zoom_reset_button");
29662971
zoom_reset_button->set_theme_type_variation(SceneStringName(FlatButton));
29672972
zoom_reset_button->set_visible(show_zoom_buttons);
29682973
zoom_reset_button->set_tooltip_text(ETR("Zoom Reset"));
@@ -2971,6 +2976,7 @@ GraphEdit::GraphEdit() {
29712976
zoom_reset_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_zoom_reset));
29722977

29732978
zoom_plus_button = memnew(Button);
2979+
zoom_plus_button->set_name("_zoom_plus_button");
29742980
zoom_plus_button->set_theme_type_variation(SceneStringName(FlatButton));
29752981
zoom_plus_button->set_visible(show_zoom_buttons);
29762982
zoom_plus_button->set_tooltip_text(ETR("Zoom In"));
@@ -2981,6 +2987,7 @@ GraphEdit::GraphEdit() {
29812987
// Grid controls.
29822988

29832989
toggle_grid_button = memnew(Button);
2990+
toggle_grid_button->set_name("_toggle_grid_button");
29842991
toggle_grid_button->set_theme_type_variation(SceneStringName(FlatButton));
29852992
toggle_grid_button->set_visible(show_grid_buttons);
29862993
toggle_grid_button->set_toggle_mode(true);
@@ -2991,6 +2998,7 @@ GraphEdit::GraphEdit() {
29912998
toggle_grid_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_show_grid_toggled));
29922999

29933000
toggle_snapping_button = memnew(Button);
3001+
toggle_snapping_button->set_name("_toggle_snapping_button");
29943002
toggle_snapping_button->set_theme_type_variation(SceneStringName(FlatButton));
29953003
toggle_snapping_button->set_visible(show_grid_buttons);
29963004
toggle_snapping_button->set_toggle_mode(true);
@@ -3001,6 +3009,7 @@ GraphEdit::GraphEdit() {
30013009
toggle_snapping_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_snapping_toggled));
30023010

30033011
snapping_distance_spinbox = memnew(SpinBox);
3012+
snapping_distance_spinbox->set_name("_snapping_distance_spinbox");
30043013
snapping_distance_spinbox->set_visible(show_grid_buttons);
30053014
snapping_distance_spinbox->set_min(GRID_MIN_SNAPPING_DISTANCE);
30063015
snapping_distance_spinbox->set_max(GRID_MAX_SNAPPING_DISTANCE);
@@ -3013,6 +3022,7 @@ GraphEdit::GraphEdit() {
30133022
// Extra controls.
30143023

30153024
minimap_button = memnew(Button);
3025+
minimap_button->set_name("_minimap_button");
30163026
minimap_button->set_theme_type_variation(SceneStringName(FlatButton));
30173027
minimap_button->set_visible(show_minimap_button);
30183028
minimap_button->set_toggle_mode(true);
@@ -3023,6 +3033,7 @@ GraphEdit::GraphEdit() {
30233033
minimap_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_minimap_toggled));
30243034

30253035
arrange_button = memnew(Button);
3036+
arrange_button->set_name("_arrange_button");
30263037
arrange_button->set_theme_type_variation(SceneStringName(FlatButton));
30273038
arrange_button->set_visible(show_arrange_button);
30283039
arrange_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::arrange_nodes));
@@ -3036,8 +3047,8 @@ GraphEdit::GraphEdit() {
30363047
const float minimap_opacity = 0.65;
30373048

30383049
minimap = memnew(GraphEditMinimap(this));
3039-
top_layer->add_child(minimap);
30403050
minimap->set_name("_minimap");
3051+
top_layer->add_child(minimap);
30413052
minimap->set_modulate(Color(1, 1, 1, minimap_opacity));
30423053
minimap->set_mouse_filter(MOUSE_FILTER_PASS);
30433054
minimap->set_custom_minimum_size(Vector2(50, 50));

0 commit comments

Comments
 (0)