Skip to content

Commit 12cb6b3

Browse files
committed
Use human-readable unique names for GraphEdit's internal nodes
1 parent 28bd72a commit 12cb6b3

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

scene/gui/graph_edit.cpp

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3187,6 +3187,7 @@ GraphEdit::GraphEdit() {
31873187
panner->set_callbacks(callable_mp(this, &GraphEdit::_pan_callback), callable_mp(this, &GraphEdit::_zoom_callback));
31883188

31893189
top_layer = memnew(Control);
3190+
top_layer->set_name("_top_layer");
31903191
add_child(top_layer, false, INTERNAL_MODE_BACK);
31913192
top_layer->set_mouse_filter(MOUSE_FILTER_IGNORE);
31923193
top_layer->set_anchors_and_offsets_preset(Control::PRESET_FULL_RECT);
@@ -3239,11 +3240,13 @@ GraphEdit::GraphEdit() {
32393240
menu_panel->set_position(Vector2(10, 10));
32403241

32413242
menu_hbox = memnew(HBoxContainer);
3243+
menu_hbox->set_name("_menu_hbox");
32423244
menu_panel->add_child(menu_hbox);
32433245

32443246
// Zoom label and controls.
32453247

32463248
zoom_label = memnew(Label);
3249+
zoom_label->set_name("_zoom_label");
32473250
zoom_label->set_visible(show_zoom_label);
32483251
zoom_label->set_v_size_flags(Control::SIZE_SHRINK_CENTER);
32493252
zoom_label->set_horizontal_alignment(HORIZONTAL_ALIGNMENT_CENTER);
@@ -3252,6 +3255,7 @@ GraphEdit::GraphEdit() {
32523255
_update_zoom_label();
32533256

32543257
zoom_minus_button = memnew(Button);
3258+
zoom_minus_button->set_name("_zoom_minus_button");
32553259
zoom_minus_button->set_theme_type_variation(SceneStringName(FlatButton));
32563260
zoom_minus_button->set_visible(show_zoom_buttons);
32573261
zoom_minus_button->set_tooltip_text(ETR("Zoom Out"));
@@ -3260,6 +3264,7 @@ GraphEdit::GraphEdit() {
32603264
zoom_minus_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_zoom_minus));
32613265

32623266
zoom_reset_button = memnew(Button);
3267+
zoom_reset_button->set_name("_zoom_reset_button");
32633268
zoom_reset_button->set_theme_type_variation(SceneStringName(FlatButton));
32643269
zoom_reset_button->set_visible(show_zoom_buttons);
32653270
zoom_reset_button->set_tooltip_text(ETR("Zoom Reset"));
@@ -3268,6 +3273,7 @@ GraphEdit::GraphEdit() {
32683273
zoom_reset_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_zoom_reset));
32693274

32703275
zoom_plus_button = memnew(Button);
3276+
zoom_plus_button->set_name("_zoom_plus_button");
32713277
zoom_plus_button->set_theme_type_variation(SceneStringName(FlatButton));
32723278
zoom_plus_button->set_visible(show_zoom_buttons);
32733279
zoom_plus_button->set_tooltip_text(ETR("Zoom In"));
@@ -3278,6 +3284,7 @@ GraphEdit::GraphEdit() {
32783284
// Grid controls.
32793285

32803286
toggle_grid_button = memnew(Button);
3287+
toggle_grid_button->set_name("_toggle_grid_button");
32813288
toggle_grid_button->set_theme_type_variation(SceneStringName(FlatButton));
32823289
toggle_grid_button->set_visible(show_grid_buttons);
32833290
toggle_grid_button->set_toggle_mode(true);
@@ -3288,6 +3295,7 @@ GraphEdit::GraphEdit() {
32883295
toggle_grid_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_show_grid_toggled));
32893296

32903297
toggle_snapping_button = memnew(Button);
3298+
toggle_snapping_button->set_name("_toggle_snapping_button");
32913299
toggle_snapping_button->set_theme_type_variation(SceneStringName(FlatButton));
32923300
toggle_snapping_button->set_visible(show_grid_buttons);
32933301
toggle_snapping_button->set_toggle_mode(true);
@@ -3298,6 +3306,7 @@ GraphEdit::GraphEdit() {
32983306
toggle_snapping_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_snapping_toggled));
32993307

33003308
snapping_distance_spinbox = memnew(SpinBox);
3309+
snapping_distance_spinbox->set_name("_snapping_distance_spinbox");
33013310
snapping_distance_spinbox->set_visible(show_grid_buttons);
33023311
snapping_distance_spinbox->set_min(GRID_MIN_SNAPPING_DISTANCE);
33033312
snapping_distance_spinbox->set_max(GRID_MAX_SNAPPING_DISTANCE);
@@ -3310,6 +3319,7 @@ GraphEdit::GraphEdit() {
33103319
// Extra controls.
33113320

33123321
minimap_button = memnew(Button);
3322+
minimap_button->set_name("_minimap_button");
33133323
minimap_button->set_theme_type_variation(SceneStringName(FlatButton));
33143324
minimap_button->set_visible(show_minimap_button);
33153325
minimap_button->set_toggle_mode(true);
@@ -3320,6 +3330,7 @@ GraphEdit::GraphEdit() {
33203330
minimap_button->connect(SceneStringName(pressed), callable_mp(this, &GraphEdit::_minimap_toggled));
33213331

33223332
arrange_button = memnew(Button);
3333+
arrange_button->set_name("_arrange_button");
33233334
arrange_button->set_theme_type_variation(SceneStringName(FlatButton));
33243335
arrange_button->set_visible(show_arrange_button);
33253336
arrange_button->set_tooltip_text(ETR("Automatically arrange selected nodes."));
@@ -3333,8 +3344,8 @@ GraphEdit::GraphEdit() {
33333344
const float minimap_opacity = 0.65;
33343345

33353346
minimap = memnew(GraphEditMinimap(this));
3336-
top_layer->add_child(minimap);
33373347
minimap->set_name("_minimap");
3348+
top_layer->add_child(minimap);
33383349
minimap->set_modulate(Color(1, 1, 1, minimap_opacity));
33393350
minimap->set_mouse_filter(MOUSE_FILTER_PASS);
33403351
minimap->set_custom_minimum_size(Vector2(50, 50));

0 commit comments

Comments
 (0)