Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a node configuration warning when VoxelGI extents or subdivision size is changed, but it wasn't re-baked yet #3637

Open
Tracked by #55328
Calinou opened this issue Dec 5, 2021 · 0 comments

Comments

@Calinou
Copy link
Member

Calinou commented Dec 5, 2021

Describe the project you are working on

The Godot editor 🙂

Describe the problem or limitation you are having in your project

In Godot 4.0, VoxelGIData is fully editable at run-time. However, there are still 2 operations that require a rebake: changing the extents and changing the number of subdivisions. No warning is currently provided for this.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Emit a node configuration warning when VoxelGI's extents or subdivision size is changed, but the VoxelGIData is outdated.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Store 2 properties in VoxelGIData that includes the value of the VoxelGI's Extents Subdiv properties at the time of baking. These properties wouldn't be displayed in the editor, but they would be used within the editor to compare this value with the VoxelGI's current Extents and Subdiv properties whenever they're changed. If there's a mismatch, emit a node configuration warning.

In the master branch, this work depends on godotengine/godot#55178 being finished first. This work could also be carried over separately on the 3.x branch, so that the same warning can be provided with GIProbe.

If this enhancement will not be used often, can it be worked around with a few lines of script?

No, as VoxelGIData currently does not store the extents and subdivision level (although it could be guessed using the cell size and extents).

Is there a reason why this should be core and not an add-on in the asset library?

This is about improving 3D editor usability.

@Calinou Calinou added this to the 4.x milestone Dec 5, 2021
@Calinou Calinou changed the title Emit a node configuration warning when VoxelGI subdivision size is changed, but it wasn't re-baked yet Emit a node configuration warning when VoxelGI extents or subdivision size is changed, but it wasn't re-baked yet Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant