-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add 'Learning new features' page. #4258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Learning new features' page. #4258
Conversation
668cab3
to
a8e6855
Compare
a8e6855
to
f2b7965
Compare
It's looking good! Do you mind if I edit directly and add a commit to your PR? I'd like to do some small stylistic changes, add one or two pictures... but it's great. Regarding #4251, it's more that I don't know if it addresses a need as it stands so I'd like other people's feedback on it. I'd at least replace some descriptions by instructions and tips regarding search and navigation. |
@NathanLovato Yeah, feel free to do whatever you want. As long as what needs to get done gets done, I'm good with you doing whatever. :-) |
Leaving this here if you want to put it somewhere else. It's beyond the scope of a page about learning Godot efficiently:
|
Leaving you some general feedback as I'm editing the page. Here's a great resource until #4064 gets reviewed and merged: https://v3.vuejs.org/guide/contributing/writing-guide.html#principles The principles they use to write Vuejs's docs. I recommend looking at some of their docs' pages too. I follow a similar mindset when writing or editing docs. For instance, in the Godot docs, titles can be vague, like |
Just edited the page and moved it to a new getting_started/introduction section (following #4035, I want to remove or rename step_by_step that lead some contributors to write step-by-step instructions over explanations at times). Adding pics next. |
Done! It's ready for review I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great edits! Thanks.
Thanks for the review. |
Is it good to merge with those changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Ready to merge I think.
Thanks! |
Closes #4169
Addresses critiques of #4251 (or at least, tries to). Can end up including both or just this one, either way.
cc @NathanLovato since it'll require your review.