Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window management demo for 4.0 #740

Merged
merged 1 commit into from
May 9, 2022
Merged

Fix window management demo for 4.0 #740

merged 1 commit into from
May 9, 2022

Conversation

voylin
Copy link
Contributor

@voylin voylin commented May 7, 2022

Fixing the problem which @aaronfranke mentioned in PR #737
Some functions are not present inside of Godot 4.0 so for the time being I commented them out as this demo will probably need more changes by the end of the alpha.

@aaronfranke
Copy link
Member

The text in Godot 4 seems to be a lot larger by default, especially the size of the newline. The text on the right isn't rendering quite right, for example the value of "Size" is overlapping the "Mode". We should consider replacing the \n and have this info be inline at least for the properties with short names ("Screen0 Resolution:" probably stlll deserves two lines).

I think this is a Godot bug, but I'm getting this error from line 47 of control.gd:

E 0:00:01:0122   _physics_process: Condition "!windows.has(p_window)" is true. Returning: Size2i()
  <C++ Source>   platform/linuxbsd/display_server_x11.cpp:1719 @ window_get_size()
  <Stack Trace>  control.gd:47 @ _physics_process()

@aaronfranke aaronfranke added this to the 4.0 milestone May 7, 2022
@aaronfranke aaronfranke added the bug label May 7, 2022
@voylin
Copy link
Contributor Author

voylin commented May 7, 2022

The text in Godot 4 seems to be a lot larger by default, especially the size of the newline. The text on the right isn't rendering quite right, for example the value of "Size" is overlapping the "Mode". We should consider replacing the \n and have this info be inline at least for the properties with short names ("Screen0 Resolution:" probably stlll deserves two lines).

I think this is a Godot bug, but I'm getting this error from line 47 of control.gd:

E 0:00:01:0122   _physics_process: Condition "!windows.has(p_window)" is true. Returning: Size2i()
  <C++ Source>   platform/linuxbsd/display_server_x11.cpp:1719 @ window_get_size()
  <Stack Trace>  control.gd:47 @ _physics_process()

I'm not seeing that error. But I fixed the UI issues by removig some of the '\n' and also by using VBoxContainers.

@aaronfranke
Copy link
Member

The buttons seem too close to the edge, and we can improve the anchor points to make the UI layout cleaner:

Screenshot from 2022-05-07 21-19-57
Screenshot from 2022-05-07 21-18-33

@voylin
Copy link
Contributor Author

voylin commented May 9, 2022

The buttons seem too close to the edge, and we can improve the anchor points to make the UI layout cleaner:

Really looks better like that indeed, added the padding.

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please update the commit message to something more descriptive than "Fix".

UI Fix + fixing script to display correct information

Adding padding to the UI
@voylin
Copy link
Contributor Author

voylin commented May 9, 2022

Looks good, but please update the commit message to something more descriptive than "Fix".

'Fix' is fixed. ;)

@aaronfranke aaronfranke merged commit 4af3876 into godotengine:4.0-dev May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants