-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix window management demo for 4.0 #740
Conversation
The text in Godot 4 seems to be a lot larger by default, especially the size of the newline. The text on the right isn't rendering quite right, for example the value of "Size" is overlapping the "Mode". We should consider replacing the I think this is a Godot bug, but I'm getting this error from line 47 of
|
I'm not seeing that error. But I fixed the UI issues by removig some of the '\n' and also by using VBoxContainers. |
Really looks better like that indeed, added the padding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please update the commit message to something more descriptive than "Fix".
UI Fix + fixing script to display correct information Adding padding to the UI
'Fix' is fixed. ;) |
Fixing the problem which @aaronfranke mentioned in PR #737
Some functions are not present inside of Godot 4.0 so for the time being I commented them out as this demo will probably need more changes by the end of the alpha.