Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAP plugin emit the signal "connected" but my smartphone does not have internet #666

Open
Torguen opened this issue Dec 3, 2021 · 6 comments
Labels

Comments

@Torguen
Copy link

Torguen commented Dec 3, 2021

3.4.1 rc1 mono

Which demo project is affected:

IAP plugin for mono:
https://github.com/godotengine/godot-demo-projects/tree/master/mono/android_iap

OS/device including version:

w10 64

Issue description:

The plugin emit the "Connected" signal even though the smartphone does not have internet

Screenshots of issue:

@Torguen Torguen added the bug label Dec 3, 2021
@Torguen Torguen changed the title IAP plugin sends the signal "connected" but my smartphone does not have internet IAP plugin emit the signal "connected" but my smartphone does not have internet Dec 3, 2021
@aaronfranke
Copy link
Member

Pinging @ricardoalcantara @shahediqbal13 Btw have fun with this evil issue 🙂 (look at the number)

@shahediqbal13
Copy link
Contributor

@Torguen I have not used Godot 3.4 for my project yet. I also don't remember exactly when the connected signal is called. But I think it is also called when your device is offline. Because Google play services keep a cache for the SKU details. However, I will try to check in my implementation.

@Torguen
Copy link
Author

Torguen commented Dec 3, 2021

@Torguen I have not used Godot 3.4 for my project yet. I also don't remember exactly when the connected signal is called. But I think it is also called when your device is offline. Because Google play services keep a cache for the SKU details. However, I will try to check in my implementation.

I was thinking that but I was not sure.
If so, then I think it could be stated in the official documentation.
I was confused by this behavior because I wanted to show a message on the buttons "No connection" but then I noticed that the signal "Connected" is always emitted.

So what is the meaning of that signal?
When is the "Disconnected" signal emitted?

@Torguen
Copy link
Author

Torguen commented Dec 3, 2021

If you check this and you can confirm this:
-The plugin always emits the signal "Connected"

Then I will open a proposal for that information to be included in the official documentation.

@shahediqbal13
Copy link
Contributor

@Torguen I will try but it may take some time. Currently, I am not involved in my Godot projects, because very busy with other tasks.

@Torguen
Copy link
Author

Torguen commented Dec 3, 2021

@Torguen I will try but it may take some time. Currently, I am not involved in my Godot projects, because very busy with other tasks.

Ok I understand.
Then I will adapt my code to that current behavior of the plugin.
Thanks for the information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants