Skip to content

Update CI to use windows-2022 #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Jun 24, 2025

We're currently using windows-2019 for our Windows builds, and it looks like GitHub is going to retire it on 2025-06-30 (6 days from now):

actions/runner-images#12045

This PR updates to using windows-2022

@dsnopek dsnopek added this to the 4.x milestone Jun 24, 2025
@dsnopek dsnopek requested a review from a team as a code owner June 24, 2025 19:49
@dsnopek dsnopek added topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.3 cherrypick:4.4 labels Jun 24, 2025
@Repiteo Repiteo modified the milestones: 4.x, 4.5 Jun 24, 2025
@Repiteo
Copy link
Contributor

Repiteo commented Jun 24, 2025

Actually wait, I dunno how y'all handle milestones here. Leaving it on 4.x just in case

@Repiteo Repiteo modified the milestones: 4.5, 4.x Jun 24, 2025
@dsnopek dsnopek merged commit c45c4aa into godotengine:master Jun 24, 2025
16 checks passed
@raulsntos
Copy link
Member

Any reason not to use windows-latest? That seems to be what the main Godot repo uses:

https://github.com/godotengine/godot/blob/05640191e7c08ffe34f62de39ec52d7dcf198923/.github/workflows/windows_builds.yml#L20

@dsnopek
Copy link
Collaborator Author

dsnopek commented Jun 25, 2025

Personally, I prefer pointing at a specific version, because, theoretically, it means we won't suddenly be hit with failing builds when a new Windows version becomes available. But I say "theoretically" because we can still be hit with failing builds when GitHub decides to retire a version or do a "scheduled brownout". GitHub breaks my theory :-(

So, maybe it would, in fact, be better to use windows-latest! That probably applies to the Linux ones too

@Ivorforce
Copy link
Member

Personally, I prefer pointing at a specific version, because, theoretically, it means we won't suddenly be hit with failing builds when a new Windows version becomes available. But I say "theoretically" because we can still be hit with failing builds when GitHub decides to retire a version or do a "scheduled brownout". GitHub breaks my theory :-(

So, maybe it would, in fact, be better to use windows-latest! That probably applies to the Linux ones too

Practically, the earlier versions are probably more stable anyway. Especially right after release of a new runner, software might not yet be compatible while bugs are being ironed out. So even with the brownouts, I'd probably continue to use explicit version specifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.3 cherrypick:4.4 topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants