-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly handle Object *
arguments that were encoded as nullptr
#1405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense and is elegant, matches below as stated
6d1b443
to
db21a6e
Compare
db21a6e
to
37542dc
Compare
I've updated the PR per @reduz's requests, as well as made the And I just posted PR godotengine/godot#90394 to make the same change in the equivalent code in Godot. |
Looks great! |
Thanks for the review! |
Cherry-picked for 4.2 in PR #1465 |
Cherry-picked for 4.1 in PR #1466 |
Fixes godotengine/godot#86478
Fixes #1056
This is an alternative to PR godotengine/godot#87613, fixing the issue in godot-cpp rather than in Godot itself. I explained my reasons for wanting to fix it in godot-cpp in this comment.
This uses a ternary expression to match the code in the
encode()
method just below theconvert()
method this PR changes:I think having the symmetry between the encode/decode methods is nice, even though it leads to a very long line of code. :-)
This PR also adds an automated test which will crash on
master
, but succeed with this PR.