Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow registering "runtime classes" #1256

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Sep 29, 2023

This is the companion to PR godotengine/godot#82554

NOTE: This won't pass tests until after the Godot PR is merged.

Fixes #1255
Fixes #709

Production edit: closes godotengine/godot-roadmap#36

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Sep 29, 2023
@dsnopek dsnopek added this to the 4.x milestone Sep 29, 2023
@dsnopek dsnopek requested a review from a team as a code owner September 29, 2023 22:52
@dsnopek dsnopek changed the title [DRAFT] Allow registering "gameplay classes" [DRAFT] Allow registering "runtime classes" Feb 13, 2024
@dsnopek dsnopek changed the title [DRAFT] Allow registering "runtime classes" Allow registering "runtime classes" Feb 20, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review in depth nor test, but looks good at a glance.

Copy link

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gave a quick look and things look fine!

@dsnopek
Copy link
Collaborator Author

dsnopek commented Feb 21, 2024

Thanks for the review!

@dsnopek dsnopek merged commit f900859 into godotengine:master Feb 21, 2024
12 checks passed
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
3 participants