-
Notifications
You must be signed in to change notification settings - Fork 66
Minimize CI burden by commenting out parts of the matrix #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Minimizes CI burden by commenting out parts of the matrix so that one entry for every platform remains - Adds a commented out option for web builds using threads=no
I'm not sure I like disabling CI, it means users will have to re-enable these builds manually with a commit when cloning the repo. Edit: Actually, I'd disable |
Hmm yeah I guess you could be right. On the other hand probably not everyone would be wanting to have everything enabled by default anyways. Not every extension will (need to) work on every platform. Also one commit to enable everything doesn't sound very bad in my opinion. You will probably want to configure your stuff anyways since we have the naming predefined with the template variables. So might as well... I am not opposed to build profiles though. Haven't heard about them though (I only get weird search results). Do you mind sharing a link to a docs page?
Even better. So that would change the line float-precision: [single, double] to this here then?: float-precision: [
single,
#double
] |
I don't think they're documented yet :/ They're used to compile only parts of godot-cpp, and skip the rest. You can use one with the I think they need to be in a file, but as long as users don't manually use the Edit: I just remembered, we do actually have a dummy
Yep, that should work! |
You can use We follow a similar approach in godot-rust. We run 3 |
Before-After comparison
Before:
After: