Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null-check against uninitialized pointer in Gd::from_sys_init_opt() #20

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Fix null-check against uninitialized pointer in Gd::from_sys_init_opt() #20

merged 2 commits into from
Nov 16, 2022

Commits on Nov 14, 2022

  1. Fix UB in Gd::from_sys_init_opt() 

    The dereferenced type-pointer (yielding the object-ptr) was not initialized to null before usage, based on the wrong assumption that Godot would do that.
Also changes the implementation to use pointers instead of opaques.
    @Bromeon
    Bromeon committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    8d9ff8b View commit details
    Browse the repository at this point in the history

  2. Simplify Gd::from_sys_init_opt() -- from_obj_sys() instead of from_sy… 

    …s_init()
    @Bromeon
    Bromeon committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4924b44 View commit details
    Browse the repository at this point in the history