Skip to content

Commit 6cf2ab2

Browse files
goderbauerjungshik
authored andcommitted
Adds a minimal ICU data config for Flutter
This reduces the size of the ICU data file shipping with Flutter: from 6.3MB to 1.2MB uncompressed from 2.2MB to 534KB compressed (zip) See go/flutter-icu for detailed analysis. Change-Id: Iff5a4aa5286c685d5410b28d98ac8d49987d2eef Reviewed-on: https://chromium-review.googlesource.com/1144234 Reviewed-by: Jungshik Shin <jshin@chromium.org>
1 parent 297a4dd commit 6cf2ab2

File tree

6 files changed

+451
-1
lines changed

6 files changed

+451
-1
lines changed

BUILD.gn

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ config("icu_code") {
9696
# certain preprocessor defines are set.
9797
# unistr.cpp also has an unused function for non-component builds.
9898
"-Wno-unused-function",
99+
# putil.cpp contains unused variables when building for iOS simulators.
100+
"-Wno-unused-variable",
99101
]
100102
}
101103
if (is_clang || is_linux || is_android) {

README.chromium

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,9 @@ Pre-built data files are generated and checked in with the following steps
7777

7878
ix) Repeat ii) and iii) for iOS to get ios/icudtl.dat
7979

80-
x) scripts/clean_up_data_source.sh
80+
x) Repeat ii) and iii) for Flutter to get flutter/icudtl.dat
81+
82+
xi) scripts/clean_up_data_source.sh
8183

8284
This reverts the result of trim_data.sh and patch_locale.sh and
8385
make the tree ready for committing updated ICU data files for

0 commit comments

Comments
 (0)