-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISNBAT add a Carousel block caption immediately after selecting the block #1149
Comments
Duplicate of #1010 |
Bah, I reported that one too ha |
The Gallery block achieves it now though - is that something we can look into emulating @AnthonyLedesma? |
This is still a valid issue. Looks like we're handling the caption's focus with state. This method seems to be unnecessary and is overly complex. I would say that's a good place to start. |
This is resolved in WordPress 5.8. Will close in a bit of time if there are no concerns here. |
Note from @AnthonyLedesma: Logic exists within the Carousel block to direct focus away from/to the captions. We should probably beware of this logic so we can remove it if no longer relevant for 5.8. |
May not be relevant anymore but we should double-check with the refactor. Closing now to link back from refactor issue. |
Describe the bug
To follow core'sGallery block UX, the caption should only be focused when I am attempting to add a caption.
Currently the caption is focused as soon as the block is selected. This pulls my attention from the primary purpose of this block, and causes the caption's inline toolbar controls to interfere with the upload appender (which is the primary interaction at this point).
To Reproduce
Steps to reproduce the behavior:
Screenshot: Comparison of the Carousel and core Gallery blocks
Expected behavior
The caption RichText componet is focused only when I click to type in the field.
Isolating the problem:
The text was updated successfully, but these errors were encountered: