Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a custom dialect? #459

Open
Jwonsever opened this issue Nov 12, 2019 · 1 comment
Open

Using a custom dialect? #459

Jwonsever opened this issue Nov 12, 2019 · 1 comment
Labels
proposal A suggestion for a change, feature, enhancement, etc
Milestone

Comments

@Jwonsever
Copy link

Jwonsever commented Nov 12, 2019

Loosely related issues:
#234
#4

Description

I’ve been trying to find a way to integrate newRelic with pop, particularly with the postgres driver. The summary of my effort is that I need to replace the postgres dialect with a new, context driven dialect. This is impossible at the moment, mostly because a lot of the required interfaces and vars are private. This issue is a feature request to expose support for integrating custom dialects.

I have an incomplete branch which serves as a proof of concept:
https://github.com/gobuffalo/pop/compare/master...Jwonsever:jwonsever/new_relic_2?expand=1

That feature branch has a few other changes which are necessary for my specific use case, which I'm happy to adjust if we move it towards a PR. Notably, I added a context to the transaction struct, and I hacked in a special configuration for the sql driver, which would be better as an actual config option.

Expected Behavior

It should be possible to supply a custom sql dialect and configure that dialect using database.yml.

Actual Behavior

It is not possible to use a dialect not supported by pop.

Info

Using buffalo, branch example is off of pop 11.4.

@LeonB
Copy link

LeonB commented Dec 31, 2019

I'm having this issue also. I've created a custom "ssh+mysql" dialect that I want to integrate. I think of just forking pop and adding a dialect_ssh_mysql.go file.

@sio4 sio4 added this to the Proposal milestone Sep 20, 2022
@sio4 sio4 added the proposal A suggestion for a change, feature, enhancement, etc label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A suggestion for a change, feature, enhancement, etc
Projects
None yet
Development

No branches or pull requests

3 participants