Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split running into timeouts away from FileExportError #310

Open
mowies opened this issue Oct 5, 2020 · 0 comments
Open

Split running into timeouts away from FileExportError #310

mowies opened this issue Oct 5, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@mowies
Copy link

mowies commented Oct 5, 2020

I am currently implementing a small backup script using the Abstract SDK. The script just takes the master branch from all projects in my organization and puts them in a folder.

Since there's quite big files inside some projects, it seems that I often run into download timeouts.
I found this issue only by going through the SDK code myself, because the error that was returned was a FileExportError which was very confusing.

After looking though the SDK code here [1], that error is thrown either when the file download progress status is failed or the download runs into the time limit that is set up in the Files endpoint implementation [2].

I would suggest to make this behaviour a little more clear by introducing a new TimeoutError and splitting this else if block and throwing separate errors.

[1] https://github.com/goabstract/abstract-sdk/blob/master/src/endpoints/Files.js#L138-L139
[2] https://github.com/goabstract/abstract-sdk/blob/master/src/endpoints/Files.js#L15

@tommoor tommoor added the enhancement New feature or request label Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants