Skip to content

Commit 695a550

Browse files
committed
Improved comments, updated travis ci
1 parent 0a002e8 commit 695a550

File tree

6 files changed

+19
-17
lines changed

6 files changed

+19
-17
lines changed

.travis.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
language: go
22

3+
sudo: false
4+
35
go:
4-
- "1.x"
6+
- 1.6.x
7+
- 1.7.x
8+
- 1.8.x
9+
- 1.9.x
10+
- 1.10.x
11+
- 1.11.x
12+
- master
13+
14+
services:
15+
- redis-server
16+
17+
after_success:
18+
- bash <(curl -s https://codecov.io/bash)

cache/memory/memory_store.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ type Store struct {
2828
cleanupTimer *time.Timer
2929
}
3030

31+
// NewStore Create a memory cache store
3132
func NewStore(prefix string) *Store {
3233
s := &Store{
3334
items: make(map[string]Item),

cache/redis/redis_store.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ type Store struct {
1313
prefix string
1414
}
1515

16+
// NewStore Create a redis cache store
1617
func NewStore(pool *redis.Pool, prefix string) *Store {
1718
s := Store{}
1819
return s.SetPool(pool).SetPrefix(prefix)

cache/redis/redis_store_test.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,6 @@ func GetPool() *redis.Pool {
2525
if err != nil {
2626
return nil, err
2727
}
28-
if _, err := c.Do("AUTH", 123456); err != nil {
29-
c.Close()
30-
return nil, err
31-
}
32-
if _, err := c.Do("SELECT", 0); err != nil {
33-
c.Close()
34-
return nil, err
35-
}
3628
return c, nil
3729
},
3830
}

cache/store.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ type Store interface {
2222

2323
var adapters = make(map[string]Store)
2424

25+
// Register Register a cache adapter available by the adapter name.
2526
func Register(name string, adapter Store) error {
2627
if adapter == nil {
2728
return errors.New("cache: Register adapter is nil")
@@ -33,6 +34,7 @@ func Register(name string, adapter Store) error {
3334
return nil
3435
}
3536

37+
// NewCache Create a new cache by adapter name.
3638
func NewCache(adapter interface{}) (Store, error) {
3739
var store Store
3840
switch adapter.(type) {

cache/store_test.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,6 @@ func TestRedisCache(t *testing.T) {
6767
if err != nil {
6868
return nil, err
6969
}
70-
if _, err := c.Do("AUTH", 123456); err != nil {
71-
c.Close()
72-
return nil, err
73-
}
74-
if _, err := c.Do("SELECT", 0); err != nil {
75-
c.Close()
76-
return nil, err
77-
}
7870
return c, nil
7971
},
8072
}

0 commit comments

Comments
 (0)