Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows #1547

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Update workflows #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eed90c7
update workflows to use latest actions
methane Feb 5, 2024
b8a8af2
use setup-go@v5
methane Feb 5, 2024
d4963f0
use codeql@v3
methane Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,18 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
queries: +security-and-quality

- name: Autobuild
uses: github/codeql-action/autobuild@v2
uses: github/codeql-action/autobuild@v3

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v3
with:
category: "/language:${{ matrix.language }}"
10 changes: 5 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: dominikh/staticcheck-action@v1.3.0
with:
version: "2023.1.3"
version: "2023.1.6"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version update for dominikh/staticcheck-action to "2023.1.6" seems to be a typo. The action version format does not match the expected semantic versioning format used by GitHub Actions.

- dominikh/staticcheck-action@v1.3.0
+ dominikh/staticcheck-action@2023.1.6

Correct the version format to match GitHub Actions' expected semantic versioning.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
version: "2023.1.6"
version: "v1.3.0"


list:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -73,11 +73,11 @@ jobs:
fail-fast: false
matrix: ${{ fromJSON(needs.list.outputs.matrix) }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go }}
- uses: shogo82148/actions-setup-mysql@v1.21.0
- uses: shogo82148/actions-setup-mysql@v1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version change for shogo82148/actions-setup-mysql to v1 appears to be a downgrade or a typo, as it moves from a specific version (v1.21.0) to a more generic version (v1). Confirm the intended version number and ensure it supports Node.js 20.

- shogo82148/actions-setup-mysql@v1.21.0
+ shogo82148/actions-setup-mysql@v1

Verify the correct version number for shogo82148/actions-setup-mysql that supports Node.js 20.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- uses: shogo82148/actions-setup-mysql@v1
- uses: shogo82148/actions-setup-mysql@v1.21.0

with:
mysql-version: ${{ matrix.mysql }}
user: ${{ env.MYSQL_TEST_USER }}
Expand Down
Loading