Update workflows #1547

methane · 2024-02-05T09:34:21Z

Description

See https://github.com/go-sql-driver/mysql/actions/runs/7781944345

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

test (ubuntu-latest, 1.21, mariadb-10.11)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, shogo82148/actions-setup-mysql@v1.21.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Checklist

Code compiles correctly
Created tests which fail without the change (if possible)
All tests passing
Extended the README / documentation, if necessary
Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

Chores
- Updated versions of GitHub Actions in the workflows for improved performance and compatibility.

coderabbitai · 2024-02-05T09:35:14Z

Walkthrough

The modifications involve updating the versions of various GitHub Actions used in the project's CI/CD workflows. These updates are focused on ensuring the workflows utilize the latest versions of actions for checking out code, static analysis, building, and testing. This is a routine maintenance activity aimed at leveraging the latest features and improvements of the GitHub Actions ecosystem to maintain the efficiency and reliability of the automated processes.

Changes

File Path	Change Summary
`.github/workflows/...`	Updated action versions for `actions/checkout`, `github/codeql-action/...`, and `actions/setup-go`. Changed `dominikh/staticcheck-action` and `shogo82148/actions-setup-mysql` versions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f019727 and d4963f0.

Files selected for processing (2)

.github/workflows/codeql.yml (1 hunks)
.github/workflows/test.yml (2 hunks)

Additional comments: 6

.github/workflows/codeql.yml (4)

27-27: Update actions/checkout to v4 aligns with the objective to address deprecation warnings. Ensure all dependent steps are compatible with this version.

30-30: The github/codeql-action/init action is updated to v3. Verify this is the latest stable version and check for any required changes in the configuration options.

36-36: The github/codeql-action/autobuild action is updated to v3. Confirm this version is current and evaluate if there are any new or deprecated configuration settings.

39-39: The github/codeql-action/analyze action is updated to v3. Ensure this version is up-to-date and review the configuration for any adjustments needed due to the version change.

.github/workflows/test.yml (2)

17-17: Updating actions/checkout to v4 is consistent with the PR objectives. Confirm compatibility with subsequent steps.

77-77: The update of actions/setup-go to v5 aligns with the PR objectives. Verify this version is the latest and check for any new or deprecated configuration options.

coderabbitai · 2024-02-05T09:39:17Z

.github/workflows/test.yml

      - uses: dominikh/staticcheck-action@v1.3.0
        with:
-          version: "2023.1.3"
+          version: "2023.1.6"


The version update for dominikh/staticcheck-action to "2023.1.6" seems to be a typo. The action version format does not match the expected semantic versioning format used by GitHub Actions.

- dominikh/staticcheck-action@v1.3.0 + dominikh/staticcheck-action@2023.1.6

Correct the version format to match GitHub Actions' expected semantic versioning.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

version: "2023.1.6"

version: "v1.3.0"

coderabbitai · 2024-02-05T09:39:18Z

.github/workflows/test.yml

        with:
          go-version: ${{ matrix.go }}
-      - uses: shogo82148/actions-setup-mysql@v1.21.0
+      - uses: shogo82148/actions-setup-mysql@v1


The version change for shogo82148/actions-setup-mysql to v1 appears to be a downgrade or a typo, as it moves from a specific version (v1.21.0) to a more generic version (v1). Confirm the intended version number and ensure it supports Node.js 20.

- shogo82148/actions-setup-mysql@v1.21.0 + shogo82148/actions-setup-mysql@v1

Verify the correct version number for shogo82148/actions-setup-mysql that supports Node.js 20.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

- uses: shogo82148/actions-setup-mysql@v1

- uses: shogo82148/actions-setup-mysql@v1.21.0

coveralls · 2024-02-05T09:48:19Z

coverage: 82.17%. remained the same
when pulling d4963f0 on methane:update-workflows
into f019727 on go-sql-driver:master.

shogo82148

LGTM

methane added 3 commits February 5, 2024 18:23

update workflows to use latest actions

eed90c7

use setup-go@v5

b8a8af2

use codeql@v3

d4963f0

methane requested a review from shogo82148 February 5, 2024 09:39

coderabbitai bot reviewed Feb 5, 2024

View reviewed changes

shogo82148 approved these changes Feb 5, 2024

View reviewed changes

methane merged commit 097fe6e into go-sql-driver:master Feb 5, 2024
35 of 36 checks passed

methane deleted the update-workflows branch February 5, 2024 11:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update workflows #1547

Update workflows #1547

methane commented Feb 5, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 5, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

coderabbitai bot Feb 5, 2024

coderabbitai bot Feb 5, 2024

coveralls commented Feb 5, 2024

shogo82148 left a comment

	- uses: shogo82148/actions-setup-mysql@v1
	- uses: shogo82148/actions-setup-mysql@v1.21.0

Update workflows #1547

Update workflows #1547

Conversation

methane commented Feb 5, 2024 • edited by coderabbitai bot Loading

Description

Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 5, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Feb 5, 2024

Choose a reason for hiding this comment

coderabbitai bot Feb 5, 2024

Choose a reason for hiding this comment

coveralls commented Feb 5, 2024

shogo82148 left a comment

Choose a reason for hiding this comment

methane commented Feb 5, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 5, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)