Skip to content

Column Valuers broken since #690 #708

Closed
@randomjunk

Description

@randomjunk

Issue description

Implement a struct with Valuer and use it as a named value in SQL statement.
We expect it to convert to driver.Value and work.
Our current code does this all over the place (using gorm).

The problem is that the recent change to named value handling (#690) returns a hard error if it can't convert the type, whereas it should return driver.ErrSkip to allow the default converter to handle it.

Example code

type Thing struct {
 content string
}

func (t Thing) Value() (driver.Value, error) {
  return t
}

Error log

sql: converting argument $5 type: unsupported type user.VerifyNotes, a struct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions