Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Specific Retry Conditions #433

Closed
rohitkg98 opened this issue Jul 3, 2021 · 2 comments · Fixed by #436
Closed

Request Specific Retry Conditions #433

rohitkg98 opened this issue Jul 3, 2021 · 2 comments · Fixed by #436
Assignees
@rohitkg98
Labels
enhancement v2 For resty v2
Milestone
v2.7.0 Milestone

Comments

@rohitkg98
Copy link
Contributor

Currently Retry Conditions are added to the client which are then subsequently used by the request. This introduces the need to create a new client to create a request with different retry condition. A workaround would be settingclient.RetryConditions to an empty slice, which would fail is used concurrently.

I propose Request Specific RetryConditions, while keeping the client one and using combination of both. Will make a draft PR soon!
@rohitkg98 rohitkg98 mentioned this issue Jul 14, 2021
Merged
@jeevatkm jeevatkm added enhancement v2 For resty v2 labels Sep 16, 2021
@jeevatkm jeevatkm added this to the v2.7.0 Milestone milestone Sep 16, 2021
@chb0github
Copy link

Any timeline on release?

@jeevatkm
Copy link
Member

@chb0github I'm thinking of making a release once PR #476 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohitkg98 rohitkg98

Labels
enhancement v2 For resty v2
Milestone
v2.7.0 Milestone
Development

Successfully merging a pull request may close this issue.

Added RetryConditions to Request rohitkg98/resty
3 participants
@jeevatkm @chb0github @rohitkg98