Update log level to warning for errors within retry block (#587)

sandyydk · web-flow · commit e12ab69242b5 · 2023-09-17T01:08:35.000-07:00
diff --git a/request.go b/request.go
@@ -930,7 +930,7 @@ func (r *Request) Execute(method, url string) (*Response, error) {
 
 			resp, err = r.client.execute(r)
 			if err != nil {
-				r.log.Errorf("%v, Attempt %v", err, r.Attempt)
+				r.log.Warnf("%v, Attempt %v", err, r.Attempt)
 			}
 
 			return resp, err
@@ -943,6 +943,10 @@ func (r *Request) Execute(method, url string) (*Response, error) {
 		ResetMultipartReaders(r.client.RetryResetReaders),
 	)
 
+	if err != nil {
+		r.log.Errorf("%v", err)
+	}
+
 	r.client.onErrorHooks(r, resp, unwrapNoRetryErr(err))
 	return resp, unwrapNoRetryErr(err)
 }

Original file line number	Diff line number	Diff line change
`@@ -930,7 +930,7 @@ func (r Request) Execute(method, url string) (Response, error) {`
`930`	`930`
`931`	`931`	`resp, err = r.client.execute(r)`
`932`	`932`	`if err != nil {`
`933`		`- r.log.Errorf("%v, Attempt %v", err, r.Attempt)`
	`933`	`+ r.log.Warnf("%v, Attempt %v", err, r.Attempt)`
`934`	`934`	`}`
`935`	`935`
`936`	`936`	`return resp, err`
`@@ -943,6 +943,10 @@ func (r Request) Execute(method, url string) (Response, error) {`
`943`	`943`	`ResetMultipartReaders(r.client.RetryResetReaders),`
`944`	`944`	`)`
`945`	`945`
	`946`	`+ if err != nil {`
	`947`	`+ r.log.Errorf("%v", err)`
	`948`	`+ }`
	`949`	`+`
`946`	`950`	`r.client.onErrorHooks(r, resp, unwrapNoRetryErr(err))`
`947`	`951`	`return resp, unwrapNoRetryErr(err)`
`948`	`952`	`}`