Omitzero does not work with slice and map bug #1436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nodivbyzero would you kindly take a look if you get some time? Thanks |
nodivbyzero
approved these changes
Jun 5, 2025
|
Thanks @nodivbyzero for the review. Can we merge this PR if everything looks good? Also can we work on closing issues #1424 and #1430 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixed a bug where using omitzero still validated empty structs and maps. This PR ensures that if omitzero is used as a tag then empty slices and maps are not validated.
baked_in.gofile to ensure that slices and maps are considered non zero only when they are not nil and they are not empty.Check #1424 for more details.
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers