Create a new array of string containing the encoded headers instead of modifying the headers pass as param

Emile-Filteau · Emile-Filteau · commit 8f3f1762845b · 2019-11-01T13:36:48.000-04:00
diff --git a/message.go b/message.go
@@ -105,14 +105,16 @@ func (m *Message) SetBoundary(boundary string) {
 
 // SetHeader sets a value to the given header field.
 func (m *Message) SetHeader(field string, value ...string) {
-	m.encodeHeader(value)
-	m.header[field] = value
+	m.header[field] = m.encodeHeader(value)
 }
 
-func (m *Message) encodeHeader(values []string) {
+func (m *Message) encodeHeader(values []string) []string {
+	encoded := make([]string, len(values))
 	for i := range values {
-		values[i] = m.encodeString(values[i])
+		encoded[i] = m.encodeString(values[i])
 	}
+
+	return encoded
 }
 
 func (m *Message) encodeString(value string) string {

Original file line number	Diff line number	Diff line change
`@@ -105,14 +105,16 @@ func (m *Message) SetBoundary(boundary string) {`
`105`	`105`
`106`	`106`	`// SetHeader sets a value to the given header field.`
`107`	`107`	`func (m *Message) SetHeader(field string, value ...string) {`
`108`		`- m.encodeHeader(value)`
`109`		`- m.header[field] = value`
	`108`	`+ m.header[field] = m.encodeHeader(value)`
`110`	`109`	`}`
`111`	`110`
`112`		`-func (m *Message) encodeHeader(values []string) {`
	`111`	`+func (m *Message) encodeHeader(values []string) []string {`
	`112`	`+ encoded := make([]string, len(values))`
`113`	`113`	`for i := range values {`
`114`		`- values[i] = m.encodeString(values[i])`
	`114`	`+ encoded[i] = m.encodeString(values[i])`
`115`	`115`	`}`
	`116`	`+`
	`117`	`+ return encoded`
`116`	`118`	`}`
`117`	`119`
`118`	`120`	`func (m *Message) encodeString(value string) string {`